Skip to content

load plugins from marketplace apps #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Amoki merged 1 commit into from
May 19, 2021
Merged

load plugins from marketplace apps #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"dependencies": {
"@bimdata/design-system": "^0.3.4",
"@bimdata/typescript-fetch-api-client": "^6.12.0",
"@bimdata/typescript-fetch-api-client": "^6.12.1",
"@bimdata/viewer": "^1.6.2",
"@uppy/core": "^1.18.1",
"@uppy/xhr-upload": "^1.7.2",
Expand Down
23 changes: 17 additions & 6 deletions src/views/model-viewer/ModelViewer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,16 +65,28 @@ export default {

merge(pluginsConfig, spacePluginsConfig);

// Extract space specific plugins urls
const pluginUrls = currentSpace.value.features
// Extract space specific plugins urls from deprecated features
const featurePlugins = currentSpace.value.features
.filter(feature => feature.name.startsWith("viewer-plugin-"))
.map(feature => feature.name.split("viewer-plugin-")[1])
.map(pluginName => availablePlugins[pluginName])
.filter(Boolean); // keep only existing plugins

// Extract space specific plugins urls from marketplace
const appPlugins = currentSpace.value.marketplaceApps
.filter(app => app.viewerPluginsUrls && app.viewerPluginsUrls.length)
.map(app => app.viewerPluginsUrls)
.reduce((urls, acc) => {
urls.forEach(url => {
acc.push(url);
});
return acc;
}, []);

const pluginUrls = featurePlugins.concat(appPlugins);

let unwatchAccessToken;
let unwatchLocale;

onMounted(async () => {
const bimdataViewer = makeBIMDataViewer({
api: {
Expand All @@ -99,12 +111,11 @@ export default {
});

const viewer = bimdataViewer.mount("#viewer", window);

unwatchAccessToken = watch(accessToken, token => {
viewer.setAccessToken(token);
bimdataViewer.setAccessToken(token);
});
unwatchLocale = watch(locale, lang => {
viewer.$i18n.locale = lang;
bimdataViewer.setLocale(lang);
});
});

Expand Down