feat(sftp): bundle folder uploads and improve cancel/delete operations

[binaricat]

Summary

• Bundle folder uploads as single tasks - When uploading a folder from computer, show it as one aggregated task with total progress instead of individual files
• Fix cancel upload - Properly cancel external uploads by calling the correct cancel function and using unique file transfer IDs for backend tracking
• Fast folder deletion - Use SSH exec with rm -rf command for remote folder deletion instead of slow recursive SFTP rmdir
• UI improvements - Add FolderUp icon for folder upload tasks, add cancelled status toast message

Changes

Bundle folder uploads

• Added detectRootFolders helper to group entries by root folder
• Create single bundled task per folder with aggregate byte count
• Track progress across all files in the bundle

Fix cancel upload

• Each file now uses unique fileTransferId for backend cancellation tracking
• Added activeFileTransferIdsRef to track all active uploads
• Modified cancelExternalUpload to cancel all active file uploads
• Backend now checks uploadState.cancelled flag instead of just error message
• Frontend catch block checks cancelUploadRef.current to break out of loop

Fast folder deletion

• Added execSshCommand helper function in sftpBridge.cjs
• Uses client.client (underlying ssh2 Client) to execute rm -rf command
• Falls back to SFTP rmdir if SSH exec fails

Test plan

• Drag a folder from computer to SFTP pane - should show as single task with aggregate progress
• Click cancel button during folder upload - should stop immediately without errors
• Delete a large folder on remote server - should complete quickly using rm -rf

🤖 Generated with Claude Code

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 70a172216a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[binaricat]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6196c6e3c3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6196c6e3c3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[binaricat]

Addressed Review Feedback

Fixed the issues raised in the code review in commit c1959ad:

1. Mark bundle task cancelled on early loop exit

When cancelUploadRef (now handled via UploadController.isCancelled()) is detected between files, the code now marks all incomplete bundle tasks as cancelled before breaking:

if (controller?.isCancelled()) {
  wasCancelled = true;
  // Mark all created tasks as cancelled before breaking
  for (const [, bundleTaskId] of bundleTaskIds) {
    const progress = bundleProgress.get(bundleTaskId);
    if (progress && progress.completedCount < progress.fileCount) {
      callbacks?.onTaskCancelled?.(bundleTaskId);
    }
  }
  break;
}

2. Treat upload failures as failures, not cancellations

Removed wasCancelled = true from the error catch block in uploadService.ts. Now errors are properly reported via onTaskFailed callback and the result includes error field without the misleading cancelled: true.

3. Don't mask write errors as cancelled uploads

Updated useSftpModalTransfers.ts to only return cancelled: true when the transfer was actually user-cancelled. Real errors are now re-thrown to trigger proper error handling:

} catch (error) {
  const wasCancelled = cancelledTransferIdsRef.current.has(taskId);
  if (wasCancelled) {
    cancelledTransferIdsRef.current.delete(taskId);
    return { success: false, cancelled: true };
  }
  // Real error - propagate it by re-throwing
  throw error;
}

This ensures genuine failures (permission denied, disk full, connection loss) are reported with proper error messages in the UI.