Fix tmux detach focus regression on Windows (#1587) - #1600
Merged
Conversation
Replace native confirm with an in-app dialog and restore terminal cursor/focus after detach so sidebar tmux actions keep working. Co-authored-by: Cursor <cursoragent@cursor.com>
Avoid deferred tmux detach focus from stealing Radix modal focus when users open the new-session dialog immediately after detach. Co-authored-by: Cursor <cursoragent@cursor.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
window.confirm()with an in-app confirm dialog for tmux detach, avoiding broken Radix modal/focus state on Windows ElectronTest plan
npm testfortmuxActionFocus.test.tsandfocusTerminalSession.test.tsFixes #1587
Made with Cursor