Skip to content

Fix tmux detach focus regression on Windows (#1587) - #1600

Merged
binaricat merged 2 commits into
mainfrom
fix/1587-tmux-detach-terminal-focus
Jun 23, 2026
Merged

Fix tmux detach focus regression on Windows (#1587)#1600
binaricat merged 2 commits into
mainfrom
fix/1587-tmux-detach-terminal-focus

Conversation

@binaricat

Copy link
Copy Markdown
Owner

Summary

  • Replace native window.confirm() with an in-app confirm dialog for tmux detach, avoiding broken Radix modal/focus state on Windows Electron
  • Defer terminal refocus after detach and restore cursor blink plus xterm focus via a session restore event
  • Fixes sidebar tmux "new session" becoming unusable and terminal cursor blink stopping after detach

Test plan

  • On Windows, connect SSH and create a tmux session
  • Use sidebar System → tmux → Detach all
  • Verify terminal cursor blinks and input works
  • Click sidebar tmux New (+) and create another session successfully
  • Run npm test for tmuxActionFocus.test.ts and focusTerminalSession.test.ts

Fixes #1587

Made with Cursor

binaricat and others added 2 commits June 23, 2026 19:57
Replace native confirm with an in-app dialog and restore terminal cursor/focus after detach so sidebar tmux actions keep working.

Co-authored-by: Cursor <cursoragent@cursor.com>
Avoid deferred tmux detach focus from stealing Radix modal focus when users open the new-session dialog immediately after detach.

Co-authored-by: Cursor <cursoragent@cursor.com>
@binaricat
binaricat merged commit 8322a2a into main Jun 23, 2026
2 checks passed
@binaricat
binaricat deleted the fix/1587-tmux-detach-terminal-focus branch July 1, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] tmux会话分离后,光标闪烁失效,且无法使用netcatty创建tmux会话

1 participant