Fail fast on decompiler server startup errors#213
Merged
Conversation
Member
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
decompiler load --timeout SECONDS(default remains 300 seconds)log_pathwhen a new server starts successfullyMotivation
decompiler loadpreviously sent detached child output to/dev/nulland only watched the registry. A missing dependency, license problem, socket failure, or backend crash therefore looked identical to slow analysis and consumed the full five-minute timeout.We reproduced this both during an ENOWARS workload replay and locally. In the local regression case, angr initialized but the server could not bind its socket. Before this change,
loadwaited 300 seconds and reported only a generic timeout. With this change, it failed in 2.9 seconds and surfaced the exact child error:The configurable timeout also lets automation choose between a strict task budget and unusually slow initial Ghidra/IDA analysis.
Testing
tests/test_artifacts.pyplus backend-independenttest_decompiler_cli.pycases — 28 passed, 209 skipped, 1 pre-existing environment-sensitive test deselectedtests/test_artifacts.py tests/test_cli.py) — 11 passedlog_path, and the server stopped cleanlyThe decompiler CI job now includes
test_decompiler_cli.py, so the existing backend matrix also verifies that newly started IDA, Ghidra, Binary Ninja, and angr servers return a real log path where available.