🐛 Globs using hard braces being removed when using migrate script for 2.0

[anthonyshew]

Environment information

biome rage

CLI:
  Version:                      2.0.0-beta.1
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_PATH:               unset
  BIOME_LOG_PREFIX_NAME:        unset
  BIOME_CONFIG_PATH:            unset
  NO_COLOR:                     unset
  TERM:                         xterm-256color
  JS_RUNTIME_VERSION:           v20.11.1
  JS_RUNTIME_NAME:              node
  NODE_PACKAGE_MANAGER:         npm/10.2.4

Biome Configuration:
  Status:                       Loaded successfully
  Path:                         /Users/anthonyshew/projects/closed/front/biome.jsonc
  Formatter enabled:            true
  Linter enabled:               true
  Assist enabled:               true
  VCS enabled:                  true

Workspace:
  Open Documents:               0

What happened?

In testing 2.0.0-beta.1 with our codebase, I ran the migration command and noticed that, during the conversion, globs including hard brace characters([, ]) are being removed while converting files.ignore to files.includes in biome.jsonc.

I'm seeing references to these characters in the glob validation in crates/biome_glob/src/lib.rs and crates/biome_json_parser/src/lexer/mod.rs that make it appear Biome thinks these aren't valid file path characters. My guess is that these globs are being thrown out by migrate when not passing validation with migrate, though I'm unable to confirm.

As far as I'm aware, these characters are valid on all major platforms. I couldn't find a specific reason for these to be disallowed, but it appears looking at tests that they're meant to prevent capturing patterns in file extensions.

I unfortunately don't have time at the moment to contribute a fix, so reporting an Issue instead. Happy to provide further information if needed.

Expected result

Keep these globs with these characters.

Code of Conduct

• I agree to follow Biome's Code of Conduct

[Conaclos]

These characters have to be escaped in the globs. The proper fix is to add escaping when we run biome migrate. This avoids conflicts with character classes. Note that biome_glob is very conservative, it is intentional.
Could you share one of your glob using hard braces?

[anthonyshew]

An example glob would be /app/foo/[bar]/page.tsx.

[Conaclos]

An example glob would be /app/foo/[bar]/page.tsx.

I am suprised that [bar] was interpreted as a literal and not as a character class in 1.9.4 and below.

[anthonyshew]

Thanks, @Conaclos!