refactor(assist/useSortedAttributes): natural sorting and avoid cloning#5418
Merged
refactor(assist/useSortedAttributes): natural sorting and avoid cloning#5418
Conversation
35c4cea to
78b60fc
Compare
ematipico
approved these changes
Mar 23, 2025
CodSpeed Performance ReportMerging #5418 will not alter performanceComparing Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The main goal of this PR is to change the sorting algorithm: we now use a naturl sort.
useSortedAttributesheavily use cloning.I reduced the number of cloning and allocations. There is room for improvements, however this will require changing the code structure.
We now also check if the props are sorted before emitting a signal.
Also we now use unstable sort.
Test Plan
I added a test.