Skip to content

Conversation

@greed2411
Copy link
Contributor

This PR contains the changes mentioned in report, there were 13 broken links and all were found and replaced using Google, and biosql, biojava, biojava-legacy as requested by @peterjc , I hope I did it properly this time, if not mention, I would do it right away.

For the issue: #6

@peterjc
Copy link
Member

peterjc commented Jun 20, 2017

Can you remove the results.md aka report_of_changes.md file from the pull request please?


Related to CO lines, [EMBLs AS
lines](http://www.ebi.ac.uk/embl/Documentation/User_manual/usrman.html#3_4_13)
lines]<http://ftp.ebi.ac.uk/pub/databases/embl/doc/usrman.txt#3_4_13>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be round brackets not the less than/greater than signs (for markdown links).

queries. These values needs to be precomputed by a program, see [J.
Celko, SQL for
Smarties](http://rs18.rapidshare.com/files/4441805/Trees_and_Hierarchies_in_SQL_for_Smarties.pdf).
Smarties](https://datubaze.files.wordpress.com/2016/03/celkos-trees-and-hierarchies-in-sql_2004.pdf).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hlapp I'm not sure if we should be linking to an Elsevier copyright book here - would a reference perhaps with ISBN 1-55860-920-2 be better?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, the PDF is probably unintentionally public, and is fragile as it's subject to a DMCA takedown notice from the copyright holder. I'd suggest to use the ISBN link, here's the one through Worldcat: https://www.worldcat.org/search?q=isbn%3A0128007613

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, Sir.

@peterjc
Copy link
Member

peterjc commented Jun 20, 2017

I noticed one link markup problem, and queried linking directly to a copyright book, but otherwise this looks good. Thanks for working on this.

@greed2411
Copy link
Contributor Author

I did the changes you asked for Sir, , I removed the report_of_changes.md and changed <> to ()

As of rights to use that link for the book, I can't say anything you guys decide.

I've got one humble request to ask you @peterjc I know it's too much to ask, but this is my first contribution to open source and you guys have directed me in the right way, and I can't thank enough, I've started pursuing bioinformatics and going to be a sophomore, Is it okay to ask to be a part of your organization @biosql, I just did the documentation, but sure can help you guys a lot in the near future. What do you say?

Thanks, for the opportunity.

@peterjc
Copy link
Member

peterjc commented Jun 20, 2017

BioSQL is not currently a very active project, so it is lucky to have you making your first open source project contributions here:

https://github.com/biosql/biosql/graphs/contributors
https://github.com/biosql/biosql.github.io/graphs/contributors

If this and SQL is something you are interested in, then perhaps you might like to work on the programming language specific bindings for BioSQL in Perl, Python, Ruby or Java, under the BioPerl, Biopython, BioRuby or BioJava projects respectively?

However, there are hundreds of open source bioinformatics tools and projects, so if you approach learning new tools with this kind of positive attitude you are bound to be able to make other useful contributions - probably starting with documentation fixes, but later code bug fixes, etc.

I'm going to leave further review of this pull request to Hilmar (BioSQL project lead) to approve.

@peterjc peterjc requested a review from hlapp June 20, 2017 14:42
@greed2411
Copy link
Contributor Author

Yes thanks a lot, I'll try to make my learning curve steeper in the upcoming days and try to contribute as much as possible to you guys and other Open Source projects.

Nonetheless, thanks for this opportunity @peterjc for being supportive throughout the PR and @hlapp for BioSQL.

@hlapp hlapp merged commit ac32489 into biosql:master Jun 20, 2017
@hlapp
Copy link
Member

hlapp commented Jun 20, 2017

Is it okay to ask to be a part of your organization @biosql, I just did the documentation, but sure can help you guys a lot in the near future. What do you say?

Hi @jaiimmortal - as @peterjc's comment, with your contribution you've become part of the Biosql contributors already 😄 But if you're interested in engaging more with the wider community that the Biosql project is a part of, you might want to check out the Open Bioinformatics Foundation (OBF). OBF does maintain a membership to which you can sign up if you haven't already. And it'd be great to see you at a BOSC conference.

@greed2411
Copy link
Contributor Author

Ooh thanks for that information, and I can't express my gratitude properly @hlapp , I'll stick around and start helping out ppl, and thanks for the invite but I don't think I can attend the conference, I'm from India.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants