Update params - #971
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the analyzer’s UI/CLI parameterization and localization around evaluation metrics and outputs, adding a training data-loading thread control, Parquet as a batch-output option, and making accuracy messaging/defaults consistent with the underlying evaluation behavior.
Changes:
- Add a configurable “data loading threads” setting to the training UI and plumb it into training execution.
- Add Parquet as a selectable batch-analysis output type and show “additional columns” options for both CSV and Parquet.
- Update evaluation defaults (exclude accuracy by default), add CLI argument validation/help, and expand localized strings to reflect the “accuracy is misleading” rationale.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| birdnet_analyzer/lang/zh_TW.json | Updates accuracy info text; adds Parquet output label and training threads strings (Traditional Chinese). |
| birdnet_analyzer/lang/tlh.json | Updates accuracy info text; adds Parquet output label and training threads strings (Klingon). |
| birdnet_analyzer/lang/se.json | Updates accuracy info text; adds Parquet output label and training threads strings (Northern Sami file). |
| birdnet_analyzer/lang/ru.json | Updates accuracy info text; adds Parquet output label and training threads strings (Russian). |
| birdnet_analyzer/lang/pt-br.json | Updates accuracy info text; adds Parquet output label and training threads strings (Portuguese—Brazil). |
| birdnet_analyzer/lang/id.json | Updates accuracy info text; adds Parquet output label and training threads strings (Indonesian). |
| birdnet_analyzer/lang/fr.json | Updates accuracy info text; adds Parquet output label and training threads strings (French). |
| birdnet_analyzer/lang/fi.json | Updates accuracy info text; adds Parquet output label and training threads strings (Finnish). |
| birdnet_analyzer/lang/en.json | Updates accuracy info text; adds Parquet output label and training threads strings (English baseline). |
| birdnet_analyzer/lang/de.json | Updates accuracy info text; adds Parquet output label and training threads strings (German). |
| birdnet_analyzer/gui/train.py | Adds training threads control, wires it into train_model, and improves autotune UX by disabling tuned fields instead of hiding the accordion. |
| birdnet_analyzer/gui/multi_file.py | Adds Parquet to output selection mapping and enables “additional columns” UI for CSV + Parquet. |
| birdnet_analyzer/evaluation/init.py | Changes default metrics away from accuracy, adds CLI validation/choices, and writes results/data tables when --output_dir is provided. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.