fix: add an empty array fallback for fields with multiple documents type#300
Merged
birkir merged 1 commit intobirkir:masterfrom Aug 7, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #300 +/- ##
=======================================
Coverage 79.34% 79.34%
=======================================
Files 108 108
Lines 2184 2184
Branches 169 153 -16
=======================================
Hits 1733 1733
- Misses 432 433 +1
+ Partials 19 18 -1
Continue to review full report at Codecov.
|
Owner
|
Thank you @pdrvsky ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By an accident I've found a bug which was causing a query to fail. When you create a field with a type of multiple documents and then publish a post without any value added it will fail on trying to access map method on null value. The fix was to simply provide an empty array fallback in
PrimeFieldDocumentclass.