Skip to content

fix(field-select): #354 return iterable value#355

Merged
birkir merged 1 commit intobirkir:masterfrom
swim:bugfix-graphql-expects-iterable-value
Oct 4, 2019
Merged

fix(field-select): #354 return iterable value#355
birkir merged 1 commit intobirkir:masterfrom
swim:bugfix-graphql-expects-iterable-value

Conversation

@swim
Copy link
Copy Markdown
Contributor

@swim swim commented Oct 4, 2019

This PR addresses #354

Please let me know if you would like a seperate test for this issue.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 4, 2019

Codecov Report

Merging #355 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #355   +/-   ##
=======================================
  Coverage   79.08%   79.08%           
=======================================
  Files         108      108           
  Lines        2414     2414           
  Branches      335      355   +20     
=======================================
  Hits         1909     1909           
+ Misses        493      492    -1     
- Partials       12       13    +1
Impacted Files Coverage Δ
...ackages/prime-field-select/src/PrimeFieldSelect.ts 92.1% <100%> (ø) ⬆️
packages/prime-core/src/utils/connect.ts 92.3% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 499090e...dd285b1. Read the comment docs.

@birkir birkir merged commit e40772d into birkir:master Oct 4, 2019
ChristianUlbrich pushed a commit to zalari/prime that referenced this pull request Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants