Skip to content

Fix dummy behavior ball approach with side offset#694

Merged
Flova merged 1 commit intomainfrom
fix/dummy_behavior_side_offset
Jun 3, 2025
Merged

Fix dummy behavior ball approach with side offset#694
Flova merged 1 commit intomainfrom
fix/dummy_behavior_side_offset

Conversation

@Flova
Copy link
Copy Markdown
Member

@Flova Flova commented Jun 2, 2025

Checklist

  • Run colcon build
  • Write documentation
  • Test on your machine
  • Test on the robot
  • Create issues for future work
  • Triage this PR and label it

@github-project-automation github-project-automation Bot moved this to 🆕 New in Software Jun 2, 2025
@Flova Flova self-assigned this Jun 2, 2025
@Flova Flova added bug Something isn't working behavior labels Jun 2, 2025
@Flova Flova moved this from 🆕 New to 👀 In review in Software Jun 2, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the ball goal calculation for the CLOSE ball target by incorporating a side offset into the angle computation.

  • Recalculates the ball approach angle using an adjusted ball v-coordinate.
  • Updates goal coordinate computations to apply the side offset.
Comments suppressed due to low confidence (2)

bitbots_behavior/bitbots_blackboard/bitbots_blackboard/capsules/pathfinding_capsule.py:185

  • [nitpick] Consider renaming 'ball_v_from_kick_foot' to a more descriptive name such as 'adjusted_ball_v' to better reflect its purpose as the side-offset adjusted ball coordinate.
ball_v_from_kick_foot = ball_v + side_offset

bitbots_behavior/bitbots_blackboard/bitbots_blackboard/capsules/pathfinding_capsule.py:188

  • The side_offset is applied both in the adjusted ball_v computation and again when calculating goal_v, which may result in an unintended double offset. Please verify whether the double application of side_offset is intentional or if one instance should be removed.
goal_v = ball_v - math.sin(angle) * distance + side_offset

@Flova Flova merged commit b6411d0 into main Jun 3, 2025
1 of 2 checks passed
@Flova Flova deleted the fix/dummy_behavior_side_offset branch June 3, 2025 07:41
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in Software Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

behavior bug Something isn't working

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants