Fix dummy behavior ball approach with side offset#694
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the ball goal calculation for the CLOSE ball target by incorporating a side offset into the angle computation.
- Recalculates the ball approach angle using an adjusted ball v-coordinate.
- Updates goal coordinate computations to apply the side offset.
Comments suppressed due to low confidence (2)
bitbots_behavior/bitbots_blackboard/bitbots_blackboard/capsules/pathfinding_capsule.py:185
- [nitpick] Consider renaming 'ball_v_from_kick_foot' to a more descriptive name such as 'adjusted_ball_v' to better reflect its purpose as the side-offset adjusted ball coordinate.
ball_v_from_kick_foot = ball_v + side_offset
bitbots_behavior/bitbots_blackboard/bitbots_blackboard/capsules/pathfinding_capsule.py:188
- The side_offset is applied both in the adjusted ball_v computation and again when calculating goal_v, which may result in an unintended double offset. Please verify whether the double application of side_offset is intentional or if one instance should be removed.
goal_v = ball_v - math.sin(angle) * distance + side_offset
JanNiklasFeld
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
colcon build