Fixed bug with api access using api_key without login/pass#60
Merged
srautiai merged 1 commit intobitbar:develfrom Jul 19, 2017
Merged
Fixed bug with api access using api_key without login/pass#60srautiai merged 1 commit intobitbar:develfrom
srautiai merged 1 commit intobitbar:develfrom
Conversation
srautiai
suggested changes
Jul 19, 2017
Contributor
srautiai
left a comment
srautiai
left a comment
There was a problem hiding this comment.
Can you make the pull request against devel branch, thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I spotted a small bug in the code - you can't execute
wait_test_run()providing only api_key and not providing username/password. That happens because inwait_test_run()you are trying to refresh token while it might be not needed in case of usingapi_key.Here you can see a fix for this that worked for me.