fix(cat): forget verb clears the economic profile on the TOOL-CALL path too - #562
Merged
Conversation
…th too #545 registered forget_memories in both dispatch systems and promised it "clears BOTH stores" — but the both-stores composition landed only in the exec_action handler. The tool-call path (the default for tool-capable providers) called forgetMemoriesMatching alone, so a "removed" skill kept living in user_economic_profile and kept driving offers/interview prompts: the exact half-forgotten failure the fix was written to end, surviving on the other dispatch path. The tool-call branch now runs forgetMemoriesMatching AND removeFromEconomicProfile in parallel (mirroring handlers/context.ts), reports both result sets in the tool content, only lists a fact as notFound when BOTH stores missed it, and counts profile-only removals as success instead of no_results. Deliberately touches only tool-executor.ts + a new test — no overlap with the open #555 matcher rework (memory.ts / context.ts), which carries the shared-matcher refactor blockers separately. New suite pins the both-stores contract on this path: union reporting, profile-only success, and both-missed no_results. 428 cat-area tests green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#545 registered forget_memories in both dispatch systems and promised it
"clears BOTH stores" — but the both-stores composition landed only in the
exec_action handler. The tool-call path (the default for tool-capable
providers) called forgetMemoriesMatching alone, so a "removed" skill kept
living in user_economic_profile and kept driving offers/interview prompts:
the exact half-forgotten failure the fix was written to end, surviving on
the other dispatch path.
The tool-call branch now runs forgetMemoriesMatching AND
removeFromEconomicProfile in parallel (mirroring handlers/context.ts),
reports both result sets in the tool content, only lists a fact as notFound
when BOTH stores missed it, and counts profile-only removals as success
instead of no_results.
Deliberately touches only tool-executor.ts + a new test — no overlap with
the open #555 matcher rework (memory.ts / context.ts), which carries the
shared-matcher refactor blockers separately.
New suite pins the both-stores contract on this path: union reporting,
profile-only success, and both-missed no_results. 428 cat-area tests green.
Co-Authored-By: Claude Fable 5 noreply@anthropic.com