fix(notifications): make the unconfigured-email warning read as an outage - #844
Merged
Conversation
…tage Peer review on the log-flood fix (PR #841) flagged that "email notifications are disabled" reads as a benign default, not the outage it is — a quiet single warning is easy to miss, and this removes the only signal that notifications are being dropped. Reworded to say plainly that emails are being discarded and name the provider, so one grep hit is enough to act on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #841 (peer review). "Email notifications are disabled" reads as a benign default, not the outage it is — a quiet single warning is easy to miss, and the guard added in #841 removes the only signal that emails are being dropped.
Rewords the once-per-process warning to say plainly that notifications are being discarded and names the provider, so one grep hit is enough to act on:
Test plan
tsc --noEmitclean🤖 Generated with Claude Code
https://claude.ai/code/session_01Y9rKLxddothnXEtY6KDziN