Fix singleton conflict caused in godot 4.7.1 - #443
Conversation
| floating_window.transient = true | ||
| floating_window.close_requested.connect(_on_window_close_requested) | ||
| editor_interface.get_base_control().add_child(floating_window) | ||
| EditorInterface.get_base_control().add_child(floating_window) |
There was a problem hiding this comment.
The problem here is this will break Beehave for anything below Godot 4.2, which is why ideally we should not change this unless it is causing us issues. For the sake of "clean code" we cannot do it, was we'd effectively make Beehave incompatible with anything below Godot 4.2
| var graph | ||
| var blackboard_vbox: VBoxContainer | ||
| var message: Label | ||
| static var frame: RefCounted |
There was a problem hiding this comment.
static was introduced somewhat during Godot 4.x development and we should avoid using it, as it makes this addon incompatible with Godot versions where static is unsupported.
| const TREE_ICON = preload("../icons/tree.svg") | ||
| const OldGraph = preload("old_graph_edit.gd") | ||
| const NewGraph = preload("new_graph_edit.gd") | ||
| # const Utils = preload("res://addons/beehave/utils/utils.gd") |
There was a problem hiding this comment.
make sure to not include any commented out code.
| if item_list.is_inside_tree() and not item_list.get_selected_items().is_empty(): | ||
| _on_item_selected(item_list.get_selected_items()[0]) | ||
| get_tree().create_timer(0.2).timeout.connect( | ||
| func(): |
There was a problem hiding this comment.
@RawsharkTang out of curiosity: what formatter are you using? A lot of files have changed here and we should avoid including unwanted reformatting changes.
We could perhaps agree to adopt the official GDQuest formatter for this repo, but that would need to happen as part of a separate PR/discussion.
There was a problem hiding this comment.
Im using gdtoolkit and gdscript formatter to format my code.
| name="Beehave" | ||
| description="馃悵 Behavior Tree addon for Godot Engine" | ||
| author="bitbrain" | ||
| version="2.9.3-dev" |
|
Thank you for your contribution @RawsharkTang. Unfortunately, this pull request contains a lot more than just the singleton conflict changes (i.e. formatting fixes and cleanups). Ideally, those need to be separated out into separate pull requests, as otherwise it is very difficult for me (in case something breaks or bugs are introduced) what PR exactly caused the change. Also be mindful that with Beehave, there is a strict compatibility approach where all Godot 4.x versions should be supported. Using things like |
bitbrain
changed the title
|
Thanks for the instructions!!! I really dont know much as first time contributing. |
6ad5e3d to
801d125
Compare
|
Im closing this pr and i will open up a new one with only the conflict fix |
|
I just forced push and found this pr's old change is lost ahhhh |
2 participants
Description
Pr for Issue442
Addressed issues
Closes #442