fix base58.decode_check()#701
Merged
achow101 merged 1 commit intobitcoin-core:masterfrom Aug 16, 2023
Merged
Conversation
The function used the full sha256 and not just the first four bytes to verify the checksum. As a result, the checksum check always fails. This breaks the BitBox02 multisig registration, which uses this function to decode xpubs. This broke when it switched to using the internal base58 library over the `base58` dependency in 674cb08. Fixes bitcoin-core#700.
Contributor
Author
|
ping @achow101. please take a look and merge/release as soon as possible. thanks! |
Member
|
ACK c31eed9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function used the full sha256 and not just the first four bytes to verify the checksum. As a result, the checksum check always fails.
This breaks the BitBox02 multisig registration, which uses this function to decode xpubs. This broke when it switched to using the internal base58 library over the
base58dependency in 674cb08.Fixes #700.