test: check ReadList return value - #338
Open
ryanofsky wants to merge 1 commit into
Open
Conversation
ReadList was originally declared void and did not return the result of read_dest.update(), silently discarding the return value. When callers pass a ReadDestTemp or other ReadDest whose update() returns a constructed value, that value was lost. Add a test to demonstrate the bug: extend FooCustom with a v3 :List(Int32) / std::vector<int> field and use the assignment pattern value.v3 = ReadField(..., ReadDestTemp<std::vector<int>>()) inside CustomReadField. This fails to compile if ReadList returns void and succeeds with the fix. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline and AI policy for information on the review process.
If your review is incorrectly listed, please copy-paste |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup to #285 (comment), adding a test to verify the
ReadListreturn value and make sure it is compatible withReadDestTemp