-
Notifications
You must be signed in to change notification settings - Fork 72
Description
I'm trying to use file script_assets_test.json mentioned in BIP341 to test my bitcoin software (not core). I am having trouble with some cases, especially those with comment inactive/*.
Some of the cases seem impossible even without trying to run them, like inactive/keypath_empty tests that have success cases with empty both scriptSig and witness. Others, like inactive/keypath_invalidsig I'm figuring out right now, only deliver success cases (in contrary to their comment), and these cases don't get verified successfully by my software (even though vast majority of the rest of the cases is), making me think these should be failure cases instead.
I've tried reading bitcoin core code to figure out if these cases will somehow get filtered out - I can't find such condition, but I'm not that good at reading C++. I haven't tried running them with bitcoin core since I don't know much about it code-wise and don't have everything set up to run it. Please let me know if these cases are wrong, or if they should in fact work as they are written.