Fix typo for size of derivedhalf1 and derivedhalf2#28
Closed
cscott wants to merge 1 commit intobitcoin:masterfrom
Closed
Fix typo for size of derivedhalf1 and derivedhalf2#28cscott wants to merge 1 commit intobitcoin:masterfrom
cscott wants to merge 1 commit intobitcoin:masterfrom
Conversation
The output of scrypt is 64 bytes; so each derivedhalf should be 32 bytes.
Author
real-or-random
added a commit
to real-or-random/bips
that referenced
this pull request
Apr 22, 2019
- Clarify that x(P) and y(P) denote integers mod p and inline the very long footnote to make it more prominent. (This ensures that bitcoin#28 is insignificant, i.e., our algorithms are correct no matter if we reject signatures with `r >= p` explicitly.) - Don't rely on the implicit assumption that the "or" operator in our pseudocode is short-circuiting. - Don't use a pair to construct a point from it's coordinates to represent coordinate in batch verification. Instead, factor the coordinate computation out to a separate function lift_x. This is more consistent with the other algorithms that delegate coordinate computations to functions.
real-or-random
added a commit
to real-or-random/bips
that referenced
this pull request
Aug 10, 2022
Make mypy type checker happy with ref impl after aggnonce=inf commit
guggero
pushed a commit
to guggero/bips
that referenced
this pull request
Sep 29, 2022
bip-taro-proof-file: unroll proof file to nested TLV, add exclusion proofs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The output of scrypt is 64 bytes; so each derivedhalf should be 32 bytes.