[BIP322] Change private key format from wif to hex#1332
Closed
azuchi wants to merge 1 commit intobitcoin:masterfrom
Closed
[BIP322] Change private key format from wif to hex#1332azuchi wants to merge 1 commit intobitcoin:masterfrom
azuchi wants to merge 1 commit intobitcoin:masterfrom
Conversation
Contributor
|
The WIF (Wallet Import Format) is a standard for representing private keys. Whatever address type you derive from them is literally up to you. Attaching an address hint to the private key serialization is precisely what the two instances you pointed to are doing, but they're still WIF. Switching to hex seems like a downgrade, as it unnecessarily removes the checksum built into WIF, and such, for no particular reason. |
Member
|
@kallewoof Close this? |
Member
|
It seems to me that the BIP author is in disagreement with this change suggestion. I recommend that this PR be closed after 2024-05-10 unless there is further activity here that indicates otherwise. |
murchandamus
added
the
Pending acceptance
Member
|
As discussed prior, I’m closing this given no additional input |
murchandamus
removed
the
Pending acceptance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The specification for deriving a bech32 address from a wif format private key does not appear to be standardized.
Some wallets, such as Electrum, set a marker in the first byte, and BIP-0178 propose an extended WIF format.
The WIF data currently described is ambiguous as to which address is should be derived, so it would be better to describe it as a hex value.