Skip to content

Revert "Fix incorrect signature test vectors in BIP322"#1336

Closed
Mertz22 wants to merge 1 commit intobitcoin:masterfrom
Mertz22:revert-1323-master
Closed

Revert "Fix incorrect signature test vectors in BIP322"#1336
Mertz22 wants to merge 1 commit intobitcoin:masterfrom
Mertz22:revert-1323-master

Conversation

@Mertz22
Copy link
Copy Markdown

@Mertz22 Mertz22 commented Jun 30, 2022

Reverts #1323

@kallewoof
Copy link
Copy Markdown
Contributor

I am pretty sure I confirmed #1323 before it was merged. Why revert?

@maflcko
Copy link
Copy Markdown
Member

maflcko commented Jun 30, 2022

Pretty sure it's spam

@kallewoof
Copy link
Copy Markdown
Contributor

All right, closing. Will reopen if given a reason.

@kallewoof kallewoof closed this Jun 30, 2022
@kyranjamie
Copy link
Copy Markdown

Afaict the BIP continues to have incorrect test vectors.

Per the tests in the Bitcoin Core, the base64 signature of "Hello World", with key from bip, should be:

AkgwRQIhAOzyynlqt93lOKJr+wmmxIens//zPzl9tqIOua93wO6MAiBi5n5EyAcPScOjf1lAqIUIQtr3zKNeavYabHyR8eGhowEhAsfxIAMZZEKUPYWI4BruhAQjzFT8FSFSajuFwrDL1Yhy

I get this result in my JS implementation.

In the bip0322-signatures repo (bottom of notebook), @wip-abramson says they'll make a PR to update this. But, it looks like it wa updated with yet another result.

@kallewoof @MarcoFalke @wip-abramson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants