BIP-376: Silent Payment input signing behavior#2139
Open
lucia-w wants to merge 1 commit intobitcoin:masterfrom
Open
BIP-376: Silent Payment input signing behavior#2139lucia-w wants to merge 1 commit intobitcoin:masterfrom
lucia-w wants to merge 1 commit intobitcoin:masterfrom
Conversation
lucia-w
commented
Apr 12, 2026
lucia-w
commented
- This PR adds a reference implementation and test vectors for Silent Payment input signing behavior.
murchandamus
added
Proposed BIP modification
Pending acceptance
Member
|
Thanks for your submission. cc'ing the author @nymius for review. |
nymius
reviewed
Apr 14, 2026
Contributor
nymius
left a comment
nymius
left a comment
There was a problem hiding this comment.
Approach NACK 8c38c9e
Thanks for working on this.
Although your changes are exercising the behavior of the signer role, my expectations for the test cases are inclined to what we already have in BIP 174 or is currently being worked on for BIP 375 (#2046)
There we have full serialized PSBT tests.
As this BIP is focused towards PSBTs, I think that's the way to proceed.
| @@ -0,0 +1,223 @@ | |||
| #!/usr/bin/env python3 | |||
| """BIP-0376 reference implementation and test vector runner. | |||
Contributor
| "tweak": "ac7b0d0420f0d4a567d9abcb8a52e02cfae21690fd8d2d5934370dcc5aaee221", | ||
| "output_pubkey": "528b75296fa646acecf3fcb7c7697f92f7645ea0e41e6ee8a66554739d2da028" | ||
| }, | ||
| "error_substr": "spend key out of range" |
Contributor
There was a problem hiding this comment.
These are unnecessary and constraint the implementation, I would remove them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.