BIP 54: grammar improvements#2151
Merged
murchandamus merged 5 commits intobitcoin:masterfrom May 7, 2026
Merged
Conversation
murchandamus
added
Proposed BIP modification
Member
|
cc: @darosior for review |
murchandamus
reviewed
May 6, 2026
darosior
reviewed
May 7, 2026
Comment on lines
+106
to
+107
| of transactions. This is because, in the Merkle tree construction, a 64-byte value may be | ||
| interpreted either as a transaction or as the concatenation of two 32-byte hashes. The former allows faking a block inclusion proof and the latter makes |
Member
There was a problem hiding this comment.
English newbie question: why prefer "concatenation" to "catenation"? Isn't it just more letter for the very same meaning? Is it simply that it's more natural to use the longer word?
Member
There was a problem hiding this comment.
They’re synonyms, but concatenation is the standard term in computer science and much more commonly used (maybe about a magnitude more often).
Contributor
Author
There was a problem hiding this comment.
TIL! I hadn't previously known that "catenation" was a word!
darosior
approved these changes
May 7, 2026
murchandamus
reviewed
May 7, 2026
Member
There was a problem hiding this comment.
LGTM, and signed off by BIP Owner.
Thanks, @nervana21 for the improvements, thanks for the quick turnaround, @darosior.
murchandamus
removed
the
Pending acceptance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR helps clarify some language used in BIP-54