bip1: Record close reason#2167
Merged
Merged
Conversation
This commit forgoes introducing a version, as the BIP has been closed for a decade and it is no longer necessary to update the readers regarding specification changes of BIP1.
murchandamus
added
the
Metadata Update
jonatack
reviewed
May 21, 2026
| 10 Oct 2015 - Added clarifications about submission process and BIP number assignment. | ||
|
|
||
| 01 Jan 2016 - Clarified early stages of BIP idea championing, collecting community feedback, etc. | ||
| * 2016-12-14: |
Member
Author
I don’t think that it adds value to record the Deployment of BIP3 in every closed BIP’s Changelog. Therefore, my preferred approach would be to fold the update to Closed into the Changelog entry that records the original closure, while recording the close reason in that context to reflect what status update was made originally. In this case, "superseded" conveys that BIP1 was replaced. |
Member
|
While it seems somewhat more true to history to record the change, it's not a strong opinion and point taken. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit forgoes introducing a version, as the BIP has been closed for a decade and it is no longer necessary to update the readers regarding specification changes of BIP1.