Skip to content

BIP 54: progress to Complete#2172

Merged
murchandamus merged 2 commits into
bitcoin:masterfrom
darosior:2605_bip54_complete
May 22, 2026
Merged

BIP 54: progress to Complete#2172
murchandamus merged 2 commits into
bitcoin:masterfrom
darosior:2605_bip54_complete

Conversation

@darosior
Copy link
Copy Markdown
Member

@darosior darosior commented May 22, 2026

I have concluded all planned work on BIP 54. I believe it represents a net improvement and is ready for adoption by the Bitcoin community. As per BIP 3, this updates its status to Complete.

@darosior darosior force-pushed the 2605_bip54_complete branch from 335850a to c476556 Compare May 22, 2026 17:53
Copy link
Copy Markdown
Member

@murchandamus murchandamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had another look at test vectors and reference implementation. Concerns and issues have been discussed on the mailing list and are documented in the proposal. LGTM.

@murchandamus murchandamus added the BIP Update by Owner PR by Author or Deputy to modify their own BIP label May 22, 2026
@murchandamus murchandamus merged commit 43a4941 into bitcoin:master May 22, 2026
4 checks passed
Copy link
Copy Markdown
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Comment thread bip-0054.md
@darosior darosior deleted the 2605_bip54_complete branch May 22, 2026 18:24
@JeremyRubin
Copy link
Copy Markdown
Contributor

process wise this seems like a fast merge

@murchandamus
Copy link
Copy Markdown
Member

murchandamus commented May 23, 2026

This PR was just a Metadata update and a link update for the reference implementation.
Updating a BIP to Complete is a determination made by the Authors to signal that they have finished their planned work.

Relevant section of BIP3:

When the authors have concluded all planned work on their proposal, are confident that their BIP represents a net improvement, is clear, comprehensive, and is ready for adoption by the Bitcoin community, they may update the BIP’s status to Complete to indicate that they recommend adoption, implementation, or deployment of the BIP. Where applicable, the authors must ensure that any proposed specification is solid, not unduly complicated, and definitive. Specification BIPs must come with or refer to a working reference implementation and comprehensive test vectors before they can be moved to Complete. Subsequently, the BIP’s content should only be adjusted in minor details, e.g., to improve language, clarify ambiguities, backfill omissions in the specification, add test vectors for edge cases, or address other issues discovered as the BIP is being adopted.

@JeremyRubin: By the way, I asked a couple days ago, whether you would agree that CTV should be Complete rather than Draft. I’m also waiting for your sign-off to publish OP_TWEAKADD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BIP Update by Owner PR by Author or Deputy to modify their own BIP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants