BIP174: Clarify proprietary fields are retained on finalization#2183
Merged
jonatack merged 1 commit intoMay 30, 2026
Conversation
Contributor
Author
|
This version has proprietary fields mentioned as a separate category than unknown fields. The other option is:
|
Member
I prefer this |
Note that the Input Finalizer retains PSBT_IN_PROPRIETARY fields it does not understand, treating them like unknown fields so it does not clear proprietary data it cannot interpret.
011fff5 to
a4668bb
Compare
Contributor
Author
|
@achow101 updated! |
Member
|
ACK a4668bb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that the Input Finalizer retains PSBT_IN_PROPRIETARY fields it does not understand, treating them like unknown fields so it does not clear proprietary data it cannot interpret.