BIP-0112 minor revision to text.#243
Merged
luke-jr merged 1 commit intobitcoin:masterfrom Nov 26, 2015
Merged
Conversation
Contributor
|
ACK |
CodeShark
force-pushed
the
BIP0112_revisions
branch
from
dc2096c to
cc90614
Compare
Contributor
|
ACK |
luke-jr
added a commit
that referenced
this pull request
Nov 26, 2015
BIP-0112 minor revision to text.
luke-jr
pushed a commit
to luke-jr/bips
that referenced
this pull request
Jan 20, 2018
This is stolen from @sstone's bitcoin#243 "reduce attack surface". This breaks compatibility, as agreed at the 2017-11-13 meeting. Note also that it does not update the test vectors. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
luke-jr
pushed a commit
to luke-jr/bips
that referenced
this pull request
Jan 20, 2018
This is Fabrice's bitcoin#243 "BOLT2, BOLT3: reduce attack surface", split out with minor polishing: - Made it an optional feature (we can insist on it if we choose even bit). - Rename from "final_scriptpubkey" to "shutdown_scriptpubkey". - Make requirements the same as shutdown's scriptpubkey, or zero-len. - Leave shutdown's scriptpubkey, just make sure it's the same or fail. - Add to accept_channel as well as open_channel. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarification on retroactive invalidation and improvement to language.