Skip to content

BIP109: BIP102 variation for a 2mb block size bump#328

Merged
luke-jr merged 3 commits intobitcoin:masterfrom
gavinandresen:bump2mb
Feb 12, 2016
Merged

BIP109: BIP102 variation for a 2mb block size bump#328
luke-jr merged 3 commits intobitcoin:masterfrom
gavinandresen:bump2mb

Conversation

@gavinandresen
Copy link
Copy Markdown
Contributor

Thanks to @luke-jr for promptly assigning a BIP number.

This was discussed on the bitcoin-dev mailing list, but that discussion went sideways fairly quickly (as do all discussions about hard forks, it seems). It is implemented in Bitcoin Classic.

<pre>
BIP: 109
Title: Block size increase to 2MB
Author: Gavin Andresen
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing email address should be in the form name <email@example.com>

@gavinandresen
Copy link
Copy Markdown
Contributor Author

Fixed the malformed author line. Removed a troll-ish comment that is not appropriate for the BIPs repository.


https://github.com/gavinandresen/bitcoin-git/tree/two_mb_bump

See also http://gavinandresen.ninja/a-guided-tour-of-the-2mb-fork
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a Copyright section according to BIP1

@btcdrak
Copy link
Copy Markdown
Contributor

btcdrak commented Feb 11, 2016

@gavinandresen Stop deleting comments you don't like on pull requests. https://archive.is/bP0OG

@gavinandresen
Copy link
Copy Markdown
Contributor Author

@luke-jr : I think the force-push-update confused the travis syntax tester doo-hickey. Let me know if I need to fix something, or if that script needs to be fixed.

@luke-jr
Copy link
Copy Markdown
Member

luke-jr commented Feb 11, 2016

@gavinandresen I believe the problem is the README.mediawiki title for the BIP doesn't match the actual BIP Title header.

@harding
Copy link
Copy Markdown
Contributor

harding commented Feb 11, 2016

@btcdrak I agree with @gavinandresen that your comment was not appropriate for the BIPs repository, I don't think he did anything inappropriate by deleting it, and I wouldn't have a problem with him deleting your repost of it in the form of an archive.is link.

This repository exists to provide information to the community about situations that affect multiple implementations. Anyone who usefully contributes to this body of knowledge is to be thanked, not yelled at for something they previously did or did not do.

@gavinandresen
Copy link
Copy Markdown
Contributor Author

@luke-jr that was exactly the problem. It'd be awesome if the travis failures were a little more user friendly (I'd volunteer to fix, but my Perl is beyond rusty).

@luke-jr
Copy link
Copy Markdown
Member

luke-jr commented Feb 12, 2016

@gavinandresen The relevant test in this case is the diff'ing. It looks for inconsistencies in README.mediawiki with the Perl-generated table (which is based on the BIP headers).

luke-jr added a commit that referenced this pull request Feb 12, 2016
BIP109:  BIP102 variation for a 2mb block size bump
@luke-jr luke-jr merged commit fe1b3b5 into bitcoin:master Feb 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants