Skip to content

Define retarget period in BIP9#390

Closed
Christewart wants to merge 1 commit intobitcoin:masterfrom
Christewart:patch-1
Closed

Define retarget period in BIP9#390
Christewart wants to merge 1 commit intobitcoin:masterfrom
Christewart:patch-1

Conversation

@Christewart
Copy link
Copy Markdown
Contributor

@Christewart Christewart commented May 19, 2016

Define the retarget period

@Christewart Christewart changed the title Update bip-0009.mediawiki Define retarget period in BIP9 May 19, 2016
@luke-jr
Copy link
Copy Markdown
Member

luke-jr commented May 21, 2016

@sipa
Copy link
Copy Markdown
Member

sipa commented May 21, 2016

"Currently" seems confusing, as the retarget interval is not something that is easy to change. The interval for BIP9 however IS easy to change.

@Christewart
Copy link
Copy Markdown
Contributor Author

@sipa What do you mean by the 'interval for BIP9'? Is this the amount of blocks that is needed for a proposed soft fork to go from 'DEFINED' to 'ACTIVE'/'FAILED'?

@sipa
Copy link
Copy Markdown
Member

sipa commented May 21, 2016 via email

@Christewart
Copy link
Copy Markdown
Contributor Author

Interesting, perhaps we should add language around that in the BIP as well. It doesn't seem like that is said explicitly in the BIP right now. I'll write something up wrt to that later. I'll also remove the word 'currently'.

@Christewart
Copy link
Copy Markdown
Contributor Author

Never mind, i'm not going to add language around the sampling interval. Assuming everyone is ok with my last change I'm not going to add any more commits.

@rustyrussell
Copy link
Copy Markdown
Contributor

Luke-Jr notifications@github.com writes:

@sipa @petertodd @gmaxwell @rustyrussell

Surprised retarget period needs definition. If you want to, I'd say
just change:

These are tallied each retarget period.

To:

These are tallied each retarget period (2016 blocks).

Cheers,
Rusty.

@sipa
Copy link
Copy Markdown
Member

sipa commented May 31, 2016

@rustyrussell's suggestion looks fine

Define the retarget period

Update bip-0009.mediawiki

Update bip-0009.mediawiki
@Christewart
Copy link
Copy Markdown
Contributor Author

@luke-jr @sipa i've changed it to what @rustyrussell suggested and rebased. Should be good to merge

@petertodd
Copy link
Copy Markdown
Contributor

Weak NACK - this isn't really detailed enough to be an implementable spec by itself, as there's other details about retarget periods that you'd need to know to actually implement this. So with that in mind I'd rather just keep calling it a "retarget period" in the spirit of "the code is the spec; bips just describe intent"

@luke-jr luke-jr closed this Jul 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants