Skip to content

BIP 49: Derivation scheme for P2WPKH-nested-in-P2SH based accounts#456

Merged
luke-jr merged 5 commits intobitcoin:masterfrom
DanielWeigl:master
Oct 5, 2016
Merged

BIP 49: Derivation scheme for P2WPKH-nested-in-P2SH based accounts#456
luke-jr merged 5 commits intobitcoin:masterfrom
DanielWeigl:master

Conversation

@DanielWeigl
Copy link
Copy Markdown
Contributor

A derivation scheme similar to BIP44 for the upcoming P2WPKH-nested-in-P2SH addresses.

The test vectors aren't finished yet, as I choose to have the BIP-number as base path (like BIP44) in it. I'll update them as soon as this gets a preliminary number assigned.

@luke-jr luke-jr added the New BIP label Oct 5, 2016
@luke-jr luke-jr changed the title Derivation scheme for P2WPKH-nested-in-P2SH based accounts BIP 49: Derivation scheme for P2WPKH-nested-in-P2SH based accounts Oct 5, 2016
@luke-jr luke-jr merged commit 544941d into bitcoin:master Oct 5, 2016
@Sjors
Copy link
Copy Markdown
Member

Sjors commented Aug 24, 2017

Looks like Ledger is using this: https://github.com/LedgerHQ/ledger-wallet-chrome/blob/master/app/src/wallet/wallet.coffee#L76-L80

@amougel it might be useful to add that to the (new) list of implementations.

@Sjors
Copy link
Copy Markdown
Member

Sjors commented Aug 25, 2017

This is different form how the addwitnessaddress RPC call works in Bitcoin Core, which uses the same private key. It even allows you to create a witness address for a private key when its "legacy" address has received funds. I don't know what the plan is future wallet UI.

Although the core wallet (currently) doesn't use BIP 44, it's still useful to note how it handles SegWit vs. "legacy" key derivation, as well as private key reuse. Perhaps that can be added to the BIP.

@DanielWeigl
Copy link
Copy Markdown
Contributor Author

Trezor is also using m/49'/0'/0'/0/0 (=first account/first receiving address, currently only at https://beta-wallet.trezor.io)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants