Skip to content

Simplify UASF Activation Logic, and update specification.#514

Closed
da2ce7 wants to merge 1 commit intobitcoin:masterfrom
da2ce7:bip148
Closed

Simplify UASF Activation Logic, and update specification.#514
da2ce7 wants to merge 1 commit intobitcoin:masterfrom
da2ce7:bip148

Conversation

@da2ce7
Copy link
Copy Markdown
Contributor

@da2ce7 da2ce7 commented Apr 10, 2017

Updated BIP 148 Activation Logic, as the timeout of this BIP is completely redundant.

@da2ce7
Copy link
Copy Markdown
Contributor Author

da2ce7 commented Apr 10, 2017

@shaolinfry please review.

@da2ce7
Copy link
Copy Markdown
Contributor Author

da2ce7 commented Apr 10, 2017

I'm going to withdraw this pull request, as dealing with the logic for a very slow hash-rate after the enforced period starts.

@da2ce7 da2ce7 closed this Apr 10, 2017
@shaolinfry
Copy link
Copy Markdown
Contributor

In case you arent aware of the discussions, the reason the date was moved to Aug 1 was exactly to handle a ridiculous drop in hashrate, regardless of how unlikely.

@dooglus
Copy link
Copy Markdown
Contributor

dooglus commented Apr 10, 2017

There's no point in having this UASF active after the SegWit activation period has timed out.

From Bitcoin's src/chainparams.cpp:

    // Deployment of SegWit (BIP141, BIP143, and BIP147)
    consensus.vDeployments[Consensus::DEPLOYMENT_SEGWIT].bit = 1;
    consensus.vDeployments[Consensus::DEPLOYMENT_SEGWIT].nStartTime = 1479168000; // November 15th, 2016.
    consensus.vDeployments[Consensus::DEPLOYMENT_SEGWIT].nTimeout = 1510704000; // November 15th, 2017.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants