Simplify UASF Activation Logic, and update specification.#515
Closed
da2ce7 wants to merge 1 commit intobitcoin:masterfrom
Closed
Simplify UASF Activation Logic, and update specification.#515da2ce7 wants to merge 1 commit intobitcoin:masterfrom
da2ce7 wants to merge 1 commit intobitcoin:masterfrom
Conversation
Contributor
|
I disagree with this change. |
Member
|
It's unclear to me how BIP 141 nodes will react to a post-timeout activation. |
Contributor
Author
|
@luke-jr from my understanding they will not enforce SegWit. |
Contributor
|
You cannot change the activation parameters of another BIP mid deployment. BIP148 is it's own soft fork. |
|
I don't think this is a good PR. |
Member
|
@da2ce7 but they may reject blocks as invalid because they fetch the full block, and don't consider witness data valid in it... |
Member
|
Closing due to NACK from @shaolinfry |
dooglus
reviewed
Apr 10, 2017
| It is hoped that miners will respond to this BIP by activating segwit early, before this BIP takes effect. Otherwise this BIP will cause the mandatory activation of the existing segwit deployment before the end of midnight November 15th 2017. | ||
| It is hoped that miners will respond to this BIP by activating segwit early, before this BIP takes effect. Otherwise this BIP may cause the mandatory activation of the existing segwit deployment before the end of midnight November 15th 2017. | ||
|
|
||
| This BIP mandatory enforces SegWit within one full 2016 block retagat intivals after August 1st 2017. |
dooglus
reviewed
Apr 10, 2017
| In chainparams.cpp: Set BIP 9 flag to never time-out. | ||
|
|
||
| - consensus.vDeployments[Consensus::DEPLOYMENT_SEGWIT].nTimeout = 1493596800; // May 1st 2017 | ||
| + consensus.vDeployments[Consensus::DEPLOYMENT_SEGWIT].nTimeout = 999999999999ULL; // Never (BIP 148) |
Contributor
There was a problem hiding this comment.
What happens to Core nodes if UASF nodes activate SegWit after November 2017? Core nodes will only recognize SegWit lock-in until November 2017.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request Enforces That SegWit is activated, even if the hash-rate is very very slow.