Run flake8 tests on all new code submissions#619
Closed
cclauss wants to merge 1 commit intobitcoin:masterfrom
Closed
Run flake8 tests on all new code submissions#619cclauss wants to merge 1 commit intobitcoin:masterfrom
cclauss wants to merge 1 commit intobitcoin:masterfrom
Conversation
flake8 testing of https://github.com/bitcoin/bips on Python 3.6.3 $ __flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics__ ``` ./bip-0069/bip-0069_examples.py:52:9: F821 undefined name 'bytearray_cmp' return bytearray_cmp(output_tuple1[1], output_tuple2[1]) ^ 1 F821 undefined name 'bytearray_cmp' ```
Member
|
Why? BIPs aren't source code, they're documents... |
Author
|
Because this repo contains ./bip-0069/bip-0069_examples.py and that file could raise a NameError exception at runtime. How can users verify the validity of implementations when the examples crash? |
cclauss
added a commit
to cclauss/bips
that referenced
this pull request
Jan 23, 2020
As discussed in bitcoin#619. `bytearray_cmp` is and undefined name in this context which has the potential to raise NameError at runtime so use `bytearr_cmp()` (which is defined on line 4) instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flake8 testing of https://github.com/bitcoin/bips on Python 3.6.3
$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics