fix example for Native P2WPKH#693
Closed
4tochka wants to merge 1 commit intobitcoin:masterfrom
bitaps-com:master
Closed
fix example for Native P2WPKH#6934tochka wants to merge 1 commit intobitcoin:masterfrom bitaps-com:master
4tochka wants to merge 1 commit intobitcoin:masterfrom
bitaps-com:master
Conversation
First input P2PKH missed public key is script sig ( P2PKH script sig : <signature> <public_key> ) Incorrect witness field bytes, changed according to bip 141: The witness is a serialization of all witness data of the transaction. Each txin is associated with a witness field. A witness field starts with a var_int to indicate the number of stack items for the txin. It is followed by stack items, with each item starts with a var_int to indicate the length. A non-witness program (defined hereinafter) txin MUST be associated with an empty witness field, represented by a 0x00.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First input P2PKH missed public key is script sig ( P2PKH script sig : <public_key> )
Incorrect witness field bytes, changed according to bip 141: The witness is a serialization of all witness data of the transaction. Each txin is associated with a witness field. A witness field starts with a var_int to indicate the number of stack items for the txin. It is followed by stack items, with each item starts with a var_int to indicate the length. A non-witness program (defined hereinafter) txin MUST be associated with an empty witness field, represented by a 0x00.