BIP 119: Add another benefit for commiting to an input's index#996
Closed
benthecarman wants to merge 2 commits intobitcoin:masterfrom
Closed
BIP 119: Add another benefit for commiting to an input's index#996benthecarman wants to merge 2 commits intobitcoin:masterfrom
benthecarman wants to merge 2 commits intobitcoin:masterfrom
Conversation
Contributor
Author
|
cc @JeremyRubin |
Contributor
|
Can you add another sentence clarifying what "to be planned around You can add a sentence like: "were the input index not to be committed, X would happen, which would be undesirable because of Y" |
Contributor
|
Based on what you describe I don't see it as an exploitable issue. E.g., imagine an output Can you make an example where concretely a bad outcome happens? It may just be me, but I'm not seeing it. |
Contributor
Author
|
@JeremyRubin you're right |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.