fuzz: cleanups for versionbits fuzzer #21489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Mar 21, 2021
|
cr ACK aa7f418 |
maflcko
reviewed
Mar 21, 2021
| if (blocks.size() + period*2 > max_blocks) break; | ||
| if (blocks.size() + 2 * period > max_blocks) break; | ||
| } | ||
| // NOTE: fuzzed_data_provider may be fully consumed at this point and should not be used further |
There was a problem hiding this comment.
The way it currently is makes way more sense to me; I had a go the other way to see if it'd make better use of fuzz magic somehow, but it doesn't; so sticking with what I like.
|
Tested ACK aa7f418 |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Apr 6, 2021
Github-Pull: bitcoin#21489 Rebased-From: aa7f418
|
Backported in #21614 |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Apr 7, 2021
Github-Pull: bitcoin#21489 Rebased-From: aa7f418
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Apr 7, 2021
Github-Pull: bitcoin#21489 Rebased-From: aa7f418
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Apr 7, 2021
Github-Pull: bitcoin#21489 Rebased-From: aa7f418
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Apr 16, 2021
Github-Pull: bitcoin#21489 Rebased-From: aa7f418
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followups for #21380, shouldn't change coverage. Marking as draft to avoid introducing conflicts for the speedy trial PRs.