random: scope environ extern to macOS, BSDs and Illumos #33714
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33714. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
fanquake
force-pushed
the
drop_some_platforms
branch
from
f24ef2b to
6feaf36
Compare
fanquake
changed the title
DrahtBot
changed the title
|
Testing on some other platforms: hebasto/bitcoin-core-nightly#79. |
Builds on the *BSD and illumos systems failed. |
fanquake
force-pushed
the
drop_some_platforms
branch
from
6feaf36 to
fcdbce4
Compare
fanquake
changed the title
| #endif | ||
|
|
||
| #ifndef WIN32 | ||
| extern char** environ; // NOLINT(readability-redundant-declaration): Necessary on some platforms |
There was a problem hiding this comment.
nit: I think the comment can be kept as-is, or just refer to "Necessary on the above platforms". Otherwise, it is just one more line to maintain.
Also, I wonder if this can just be checked at configure-time, but no strong opinion.
There was a problem hiding this comment.
Re-modified the comment. Not sure there is too much value in moving this to configure.
These platforms fail to compile with it removed.
fanquake
force-pushed
the
drop_some_platforms
branch
from
fcdbce4 to
79d6f45
Compare
5 participants
These platforms fail to compile with it removed.
macOS: #33675
BSDs / Illumos: hebasto/bitcoin-core-nightly#79.