gui: Generate bech32 addresses by default (take 2, fixup) #16497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
promag
reviewed
Jul 31, 2019
|
|
||
| if (model->wallet().getDefaultAddressType() == OutputType::BECH32) { | ||
| ui->useLegacyAddress->setCheckState(Qt::Unchecked); | ||
| if (model->node().isAddressTypeSet()) { |
There was a problem hiding this comment.
nit, to avoid nesting previous code you could do:
if (!model->node().isAddressTypeSet()) {
// Always fall back to bech32 in the gui
ui->useLegacyAddress->setCheckState(Qt::Unchecked);
} else if ...There was a problem hiding this comment.
Good point. I will leave it as is for now, to not invalidate review.
fanquake
approved these changes
Aug 6, 2019
fanquake
added a commit
that referenced
this pull request
Aug 6, 2019
fa5a4cd gui: Generate bech32 addresses by default (take 2, fixup) (MarcoFalke) Pull request description: This commit was missing from my previous pull request for some reason 🤔 : * gui: Generate bech32 addresses by default #15711 ACKs for top commit: jonasschnelli: Tested ACK fa5a4cd promag: ACK fa5a4cd. fanquake: ACK fa5a4cd Tree-SHA512: 4a38df929d7704bf08e50a2e814b2e6cd25c4165d040a84287045b44e32f4708750845520d64170ea58e41de3ca496da4625d3eb375f9528b21b364c22068a6b
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 10, 2019
…2, fixup) fa5a4cd gui: Generate bech32 addresses by default (take 2, fixup) (MarcoFalke) Pull request description: This commit was missing from my previous pull request for some reason 🤔 : * gui: Generate bech32 addresses by default bitcoin#15711 ACKs for top commit: jonasschnelli: Tested ACK fa5a4cd promag: ACK fa5a4cd. fanquake: ACK fa5a4cd Tree-SHA512: 4a38df929d7704bf08e50a2e814b2e6cd25c4165d040a84287045b44e32f4708750845520d64170ea58e41de3ca496da4625d3eb375f9528b21b364c22068a6b
domob1812
added a commit
to domob1812/namecoin-core
that referenced
this pull request
Aug 12, 2019
In constrast to bitcoin/bitcoin#16497, we need to keep the default non-bech32 for addresses until Segwit is activated on mainnet.
domob1812
added a commit
to xaya/xaya
that referenced
this pull request
Aug 12, 2019
Since Segwit is active in Xaya, we can fully reproduce the Bitcoin change bitcoin/bitcoin#16497. The change made in upstream Namecoin to keep the default at legacy is not needed here.
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Nov 25, 2021
…2, fixup) fa5a4cd gui: Generate bech32 addresses by default (take 2, fixup) (MarcoFalke) Pull request description: This commit was missing from my previous pull request for some reason 🤔 : * gui: Generate bech32 addresses by default bitcoin#15711 ACKs for top commit: jonasschnelli: Tested ACK fa5a4cd promag: ACK fa5a4cd. fanquake: ACK fa5a4cd Tree-SHA512: 4a38df929d7704bf08e50a2e814b2e6cd25c4165d040a84287045b44e32f4708750845520d64170ea58e41de3ca496da4625d3eb375f9528b21b364c22068a6b
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Nov 25, 2021
…2, fixup) fa5a4cd gui: Generate bech32 addresses by default (take 2, fixup) (MarcoFalke) Pull request description: This commit was missing from my previous pull request for some reason 🤔 : * gui: Generate bech32 addresses by default bitcoin#15711 ACKs for top commit: jonasschnelli: Tested ACK fa5a4cd promag: ACK fa5a4cd. fanquake: ACK fa5a4cd Tree-SHA512: 4a38df929d7704bf08e50a2e814b2e6cd25c4165d040a84287045b44e32f4708750845520d64170ea58e41de3ca496da4625d3eb375f9528b21b364c22068a6b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit was missing from my previous pull request for some reason 🤔 :