Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upgui: Generate bech32 addresses by default (take 2, fixup) #16497
Conversation
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
| @@ -92,10 +93,16 @@ void ReceiveCoinsDialog::setModel(WalletModel *_model) | |||
| // Last 2 columns are set by the columnResizingFixer, when the table geometry is ready. | |||
| columnResizingFixer = new GUIUtil::TableViewLastColumnResizingFixer(tableView, AMOUNT_MINIMUM_COLUMN_WIDTH, DATE_COLUMN_WIDTH, this); | |||
|
|
|||
| if (model->wallet().getDefaultAddressType() == OutputType::BECH32) { | |||
| ui->useLegacyAddress->setCheckState(Qt::Unchecked); | |||
| if (model->node().isAddressTypeSet()) { | |||
This comment has been minimized.
This comment has been minimized.
promag
Jul 31, 2019
Member
nit, to avoid nesting previous code you could do:
if (!model->node().isAddressTypeSet()) {
// Always fall back to bech32 in the gui
ui->useLegacyAddress->setCheckState(Qt::Unchecked);
} else if ...
This comment has been minimized.
This comment has been minimized.
MarcoFalke
Aug 5, 2019
Author
Member
Good point. I will leave it as is for now, to not invalidate review.
fanquake
added a commit
that referenced
this pull request
Aug 6, 2019
fa5a4cd gui: Generate bech32 addresses by default (take 2, fixup) (MarcoFalke) Pull request description: This commit was missing from my previous pull request for some reason🤔 : * gui: Generate bech32 addresses by default #15711 ACKs for top commit: jonasschnelli: Tested ACK fa5a4cd promag: ACK fa5a4cd. fanquake: ACK fa5a4cd Tree-SHA512: 4a38df929d7704bf08e50a2e814b2e6cd25c4165d040a84287045b44e32f4708750845520d64170ea58e41de3ca496da4625d3eb375f9528b21b364c22068a6b
sidhujag
added a commit
to syscoin/syscoin
that referenced
this pull request
Aug 10, 2019
…2, fixup) fa5a4cd gui: Generate bech32 addresses by default (take 2, fixup) (MarcoFalke) Pull request description: This commit was missing from my previous pull request for some reason🤔 : * gui: Generate bech32 addresses by default bitcoin#15711 ACKs for top commit: jonasschnelli: Tested ACK fa5a4cd promag: ACK fa5a4cd. fanquake: ACK fa5a4cd Tree-SHA512: 4a38df929d7704bf08e50a2e814b2e6cd25c4165d040a84287045b44e32f4708750845520d64170ea58e41de3ca496da4625d3eb375f9528b21b364c22068a6b
domob1812
added a commit
to domob1812/namecore
that referenced
this pull request
Aug 12, 2019
In constrast to bitcoin/bitcoin#16497, we need to keep the default non-bech32 for addresses until Segwit is activated on mainnet.
domob1812
added a commit
to xaya/xaya
that referenced
this pull request
Aug 12, 2019
Since Segwit is active in Xaya, we can fully reproduce the Bitcoin change bitcoin/bitcoin#16497. The change made in upstream Namecoin to keep the default at legacy is not needed here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
MarcoFalke commentedJul 30, 2019
This commit was missing from my previous pull request for some reason🤔 :