Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui: Generate bech32 addresses by default (take 2, fixup) #16497

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@MarcoFalke
Copy link
Member

MarcoFalke commented Jul 30, 2019

This commit was missing from my previous pull request for some reason 馃 :

  • gui: Generate bech32 addresses by default #15711
@jonasschnelli

This comment has been minimized.

Copy link
Member

jonasschnelli commented Jul 30, 2019

Thanks!
Tested ACK fa5a4cd

@DrahtBot DrahtBot added the GUI label Jul 30, 2019
Copy link
Member

promag left a comment

ACK fa5a4cd.

@@ -92,10 +93,16 @@ void ReceiveCoinsDialog::setModel(WalletModel *_model)
// Last 2 columns are set by the columnResizingFixer, when the table geometry is ready.
columnResizingFixer = new GUIUtil::TableViewLastColumnResizingFixer(tableView, AMOUNT_MINIMUM_COLUMN_WIDTH, DATE_COLUMN_WIDTH, this);

if (model->wallet().getDefaultAddressType() == OutputType::BECH32) {
ui->useLegacyAddress->setCheckState(Qt::Unchecked);
if (model->node().isAddressTypeSet()) {

This comment has been minimized.

Copy link
@promag

promag Jul 31, 2019

Member

nit, to avoid nesting previous code you could do:

if (!model->node().isAddressTypeSet()) {
    // Always fall back to bech32 in the gui
    ui->useLegacyAddress->setCheckState(Qt::Unchecked);
} else if ...

This comment has been minimized.

Copy link
@MarcoFalke

MarcoFalke Aug 5, 2019

Author Member

Good point. I will leave it as is for now, to not invalidate review.

Copy link
Member

fanquake left a comment

ACK fa5a4cd

bech32

@fanquake fanquake merged commit fa5a4cd into bitcoin:master Aug 6, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fanquake added a commit that referenced this pull request Aug 6, 2019
fa5a4cd gui: Generate bech32 addresses by default (take 2, fixup) (MarcoFalke)

Pull request description:

  This commit was missing from my previous pull request for some reason 馃 :

  *    gui: Generate bech32 addresses by default #15711

ACKs for top commit:
  jonasschnelli:
    Tested ACK fa5a4cd
  promag:
    ACK fa5a4cd.
  fanquake:
    ACK fa5a4cd

Tree-SHA512: 4a38df929d7704bf08e50a2e814b2e6cd25c4165d040a84287045b44e32f4708750845520d64170ea58e41de3ca496da4625d3eb375f9528b21b364c22068a6b
@MarcoFalke MarcoFalke deleted the MarcoFalke:1907-guiBech32Take2 branch Aug 6, 2019
sidhujag added a commit to syscoin/syscoin that referenced this pull request Aug 10, 2019
鈥2, fixup)

fa5a4cd gui: Generate bech32 addresses by default (take 2, fixup) (MarcoFalke)

Pull request description:

  This commit was missing from my previous pull request for some reason 馃 :

  *    gui: Generate bech32 addresses by default bitcoin#15711

ACKs for top commit:
  jonasschnelli:
    Tested ACK fa5a4cd
  promag:
    ACK fa5a4cd.
  fanquake:
    ACK fa5a4cd

Tree-SHA512: 4a38df929d7704bf08e50a2e814b2e6cd25c4165d040a84287045b44e32f4708750845520d64170ea58e41de3ca496da4625d3eb375f9528b21b364c22068a6b
domob1812 added a commit to domob1812/namecore that referenced this pull request Aug 12, 2019
In constrast to bitcoin/bitcoin#16497, we need
to keep the default non-bech32 for addresses until Segwit is activated
on mainnet.
domob1812 added a commit to xaya/xaya that referenced this pull request Aug 12, 2019
Since Segwit is active in Xaya, we can fully reproduce the Bitcoin change
bitcoin/bitcoin#16497.  The change made in upstream
Namecoin to keep the default at legacy is not needed here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can鈥檛 perform that action at this time.