fix(electrum): verify txid of server-returned transactions#2188
Merged
evanlinjin merged 1 commit intobitcoindevkit:masterfrom Apr 24, 2026
Merged
fix(electrum): verify txid of server-returned transactions#2188evanlinjin merged 1 commit intobitcoindevkit:masterfrom
evanlinjin merged 1 commit intobitcoindevkit:masterfrom
Conversation
evanlinjin
requested changes
Apr 23, 2026
Member
evanlinjin
left a comment
evanlinjin
left a comment
There was a problem hiding this comment.
ConceptACK
I think the test is overkill - let's remove it. Otherwise, LGTM.
Member
|
@tnull Let me know if you would like me to take over (I know you are busy). |
An Electrum server could return an arbitrary transaction when `fetch_tx()` requests a specific txid. The returned transaction was cached and used without verifying that its computed txid matches the requested one. Add a verification check that `tx.compute_txid() == txid` after fetching from the server, returning an error on mismatch. Signed-off-by: Elias Rohrer <dev@tnull.de>
tnull
force-pushed
the
2026-04-electrum-txid-check
branch
from
0e68465 to
d101a09
Compare
Contributor
Author
Dropped the test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An Electrum server could return an arbitrary transaction when
fetch_tx()requests a specific txid. The returned transaction was cached and used without verifying that its computed txid matches the requested one.Add a verification check that
tx.compute_txid() == txidafter fetching from the server, returning an error on mismatch. Include a unit test with a mock Electrum client that exercises both the mismatch rejection and the matching-txid happy path.