docs(wallet): fix misleading RBF comment in create_tx

[va-an]

Description

Fix misleading comment in create_tx regarding empty tx output logic. This addresses a documentation nitpick brought up by the 2024 WizardSardine report.

• Replaced incorrect RBF example with sweeping UTXOs
• Reordered comment items to match the code's condition order

Closes #45

Changelog notice

Fixed:

• Fix docs for Wallet:create_tx when empty output vector

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran just p before pushing

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.04%. Comparing base (fb7681a) to head (76a8cc6).
⚠️ Report is 10 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #422   +/-   ##
=======================================
  Coverage   80.04%   80.04%           
=======================================
  Files          24       24           
  Lines        5336     5336           
  Branches      242      242           
=======================================
  Hits         4271     4271           
  Misses        987      987           
  Partials       78       78           

Flag	Coverage Δ
rust	80.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ValuedMammal]

ACK 62409a5 I agree the comment was confusing and at least now it better describes what the code is doing.

[luisschwab]

Can you squash the commits?

[luisschwab]

ACK 76a8cc6