Skip to content

Conversation

@nabijaczleweli
Copy link

$ git grep AllAttemptsErrored
src/client.rs:                        return Err(Error::AllAttemptsErrored(errors));
src/client.rs:                                        return Err(Error::AllAttemptsErrored(errors));

fixed here

src/raw_client.rs:    Err(Error::AllAttemptsErrored(errors))

already correctly collected

src/types.rs:    AllAttemptsErrored(Vec<Error>),
src/types.rs:            Error::AllAttemptsErrored(errors) => {

consumers

Closes #186

Copy link
Contributor

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK, however you still have unwrap in your code which isn't great. Maybe it will be better to log the warning first before placing the error into the errors vec.

  $ git grep AllAttemptsErrored
  src/client.rs:                        return Err(Error::AllAttemptsErrored(errors));
  src/client.rs:                                        return Err(Error::AllAttemptsErrored(errors));
fixed here
  src/raw_client.rs:    Err(Error::AllAttemptsErrored(errors))
already correctly collected
  src/types.rs:    AllAttemptsErrored(Vec<Error>),
  src/types.rs:            Error::AllAttemptsErrored(errors) => {
consumers

Closes bitcoindevkit#186
@nabijaczleweli
Copy link
Author

nabijaczleweli commented Dec 7, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Routinely returns AllAttemptsErrored([]) on failed requests

2 participants