Conversation
Collaborator
|
Yeah, I agree with the change and I don't know why I said "wallet" instead of "input". However, this PR also needs to make the same change to the link definition at the bottom of the newsletter or the page won't render correctly (that's why the tests are failing). Thanks for the PR and the congrats! |
Collaborator
|
Thanks @MaxHillebrand, good catch! Can you force-push after updating the link name at the bottom? |
Author
|
Sorry, I missed that link reference at the bottom... It's added now, but in a separate commit. Is this alright if you now do a squash merge commit @jonatack? |
As far as I know the term, as well as in the wiki that is linked, the term discussed here is called the `common input ownership assumption`, and not `common wallet ownership assumption`. If I am mistaken here, and `wallet` is the intended word, then please dismiss and close the PR.
Contributor
|
Squashed and merged. Thanks Max! |
ghost
deleted the
patch-1
branch
June 8, 2020 15:33
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I know the term, as well as in the wiki that is linked, the term discussed here is called the
common input ownership assumption, and notcommon wallet ownership assumption.If I am mistaken here, and
walletis the intended word, then please dismiss and close the PR.Congrats on #100 - this is incredible work!