fix(ui): remove redundant note from frontend placeholder page - #251
Merged
Conversation
The placeholder already explains how to build the bundle; the extra released-binary disclaimer added noise without helping operators.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the released-binary disclaimer from the embedded frontend placeholder page. The page already explains that the Vite bundle was not built and how to rebuild it.
Changes
go buildfrominternal/ui/dist/index.htmlTest plan
make testmake lintscripts/e2e-milestone1.shdpm localnet uifrom a plaingo buildand confirm the placeholder still renders build instructions without the removed noteChecklist
website/synced if any mirroreddocs/*.mdchanged)TODO(#issue)comment)