docs(ui): align placeholder page with CONTRIBUTING.md workflows - #255
Merged
Conversation
Developers hitting the embedded placeholder need clear guidance on when make build alone is expected versus make ui or the Vite dev loop.
Contributor
Author
|
It has a nice UI to tell user that they need to run the correct command instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/ui/dist/index.htmlto explain why the placeholder is tracked and point contributors toCONTRIBUTING.md.make buildfor Go-only work,make uito embed the production UI, and the Vite dev loop for hot-reload UI development.Test plan
DEVKIT_FRONTEND_PLACEHOLDERsentinel is still present forIsPlaceholderBundle().dpm localnet uiwith a binary built viamake buildand confirm the updated placeholder page renders.