test(e2e): use remove instead of clean in milestone 1 script - #256
Merged
Conversation
The canonical teardown verb is now `localnet remove`; update the e2e suite to exercise it (including M1-RMV-001) so CI matches shipped CLI.
Run bash -n on scripts/e2e-milestone1.sh when the script or workflow changes on pull requests and main pushes.
This reverts commit 31f26cf.
zheli
force-pushed
the
test/e2e-milestone1-use-remove
branch
from
July 11, 2026 17:03
98284a1 to
b24249f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
localnet cleaninvocations inscripts/e2e-milestone1.shwith the canonicallocalnet removecommand (positional instance name).remove --helpinstead of the deprecatedcleanalias.Test plan
bash -n scripts/e2e-milestone1.shmake build && scripts/e2e-milestone1.sh(requires Docker + ~30 min)