fix(localnet): remove prunes adopted external volumes - #269
Closed
srikanth-bitdynamics wants to merge 1 commit into
Closed
fix(localnet): remove prunes adopted external volumes#269srikanth-bitdynamics wants to merge 1 commit into
srikanth-bitdynamics wants to merge 1 commit into
Conversation
`localnet remove` tears down via `docker compose down --volumes`, which only drops volumes Compose created — not ones it adopted as external (a volume left by an earlier run of the same project, common on a persistent CI runner). Those survived, so remove violated its "reclaim everything" contract and left canton-<name>_postgres / _domain-upgrade-dump behind (the e2e M1-RMV-001 / M1-CLN-001 "volumes remain after remove" failure, also seen on main). remove now prunes any lingering `<project>_*` volumes by project prefix after the compose teardown. The `_` anchor scopes it to the exact project, so a sibling instance's volumes are never touched.
zheli
requested changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
localnet removetears down withdocker compose down --volumes, which onlydrops volumes Compose created — not ones it adopted as external (a
volume left by an earlier run of the same project). Those survive, so
removeviolates its "reclaim everything" contract. On the persistent self-hosted e2e
runner this strands
canton-<name>_postgres/_domain-upgrade-dumpand failsM1-RMV-001/M1-CLN-001("volumes remain after remove") — currently red onmaintoo, and the reason the e2e workflow carries a manual volume-prunecleanup step as a band-aid.
Fix
After the compose teardown,
removeprunes any lingering<project>_*volumesby project prefix (
ComposeRunner.PruneProjectVolumes). The_anchor scopesit to the exact project, so a sibling instance's volumes are never touched
(verified against real docker).
Tests
TestPruneProjectVolumesRemovesAdopted/...NoopWhenEmpty(compose_test.go).name=^<project>_filter matches the project'svolumes, excludes a sibling's, and
rm -fclears them.Once merged, the workflow's manual volume-prune cleanup steps become redundant
and can be dropped (left for a follow-up to keep this diff focused).