test(integration): fix stale RunUp call (Integration workflow red on main) - #271
Merged
Conversation
RunUp was refactored to take a Progress (RunUp(ctx, prog, opts)), but the build-tagged integration_test.go still passed (ctx, os.Stdout, os.Stderr, opts). Normal `go test` doesn't compile integration-tagged files, so it rotted undetected — the Integration workflow has been red on main with 'too many arguments in call to RunUp'. Wrap stdout/stderr in NewTextProgress, matching the CLI's RunUp call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Integration workflow fails to build on
main:internal/localnet/integration_test.go:68: too many arguments in call to RunUp.RunUpwas refactored to take aProgress(RunUp(ctx, prog, opts)), but thebuild-tagged
integration_test.gostill calls the oldRunUp(ctx, os.Stdout, os.Stderr, opts). Normalgo test ./...doesn't compile//go:build integrationfiles, so it rotted undetected.Fix
Wrap stdout/stderr in
NewTextProgress— exactly what the CLI passes toRunUp.Verified:
go vet -tags integration ./...andgo build -tags integration ./...now pass.
One of two independent CI breakages on
mainfound while validating theobservability + remove work (the other is the download-artifact pin, #270).