test(e2e): clarify DPM-DAR-001 scope and add bats summary to CI - #282
Merged
Conversation
- Rename the test to make explicit it only exercises the build step of `dpm localnet dar build-upload` (--build-only); no LocalNet or upload RPC is involved. - e2e-dpm-test action: tee bats TAP output and render a markdown pass/fail table to $GITHUB_STEP_SUMMARY so results are visible in the GitHub Actions run summary without opening logs.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dpm localnet dar build-upload(--build-only) — no LocalNet is started and the upload RPC is never invoked. A minimal Daml project is scaffolded on the fly bydpm_make_project, so the test remains a real, compilable build.e2e-dpm-testcomposite action now tees the bats TAP output and renders a markdown pass/fail table to$GITHUB_STEP_SUMMARY, so results show up directly in the GitHub Actions run summary instead of requiring a log dive.Changes
e2e-tests/dpm-dar-001.bats: clarified header comment and@testtitle..github/actions/e2e-dpm-test/action.yml:set -o pipefail+teethe TAP stream to a file; newif: always()step parses it into a markdown table (✅/❌/⏭️) with pass/fail/skip totals.Testing
bats --count e2e-tests/dpm-dar-001.batsconfirms the file still parses with 1 test.ok/not ok/# skiplines, including a test title containing special characters.ruby -ryamlvalidated both modified YAML files parse correctly.shellcheckon the new summary step's script logic (no issues beyond expected missing-shebang notice for the inline snippet).No new third-party actions or dependencies were introduced; nothing requires SHA-pinning.