Skip to content

fix(localnet): always list every registered instance - #296

Merged
zheli merged 1 commit into
mainfrom
zzz/720aa5a4
Jul 30, 2026
Merged

fix(localnet): always list every registered instance#296
zheli merged 1 commit into
mainfrom
zzz/720aa5a4

Conversation

@zheli

@zheli zheli commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary

localnet list now always shows every registered instance and no longer requires --all to include stopped/failed entries.

Changes

  • remove the --all flag wiring from localnet list
  • remove running/creating-only filtering from list row collection
  • update list text empty-state messaging to match always-show-all behavior
  • add regression test coverage for stopped and failed instance visibility
  • document this user-visible behavior change in docs/changes-from-proposal.md

Test plan

  • make test
  • make lint
  • scripts/e2e/run-all.sh
  • go test ./internal/localnet/ -count=1 -run 'List|StatusGlyph|FormatPort'
  • go test ./internal/cli/localnet/ -count=1 -run 'List'

Checklist

  • Tests pass locally
  • No coverage regression on touched code
  • Docs updated (and website/ synced if any mirrored docs/*.md changed)
  • CLI ↔ Web UI parity maintained (or follow-up issue + TODO(#issue) comment)

Remove the list-only --all filter so stopped and failed instances are visible by default, matching operator expectations and UI behavior.
@zheli
zheli marked this pull request as ready for review July 30, 2026 10:36
@zheli
zheli merged commit eb489d0 into main Jul 30, 2026
4 checks passed
@zheli
zheli deleted the zzz/720aa5a4 branch July 30, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant