Skip to content

Private Dockerfile - #355

Closed
matiasgarcia wants to merge 7 commits into
masterfrom
private-repo-dockerfile
Closed

Private Dockerfile#355
matiasgarcia wants to merge 7 commits into
masterfrom
private-repo-dockerfile

Conversation

@matiasgarcia

@matiasgarcia matiasgarcia commented Apr 9, 2021

Copy link
Copy Markdown
Contributor

Fixes https://github.com/bitex-la/storyboard/issues/1699

How to test:

docker build --no-cache --build-arg GITHUB_PERSONAL_TOKEN=<YOUR_GITHUB_PERSONAL_TOKEN> .

Get Access Token from https://github.com/settings/tokens -> Mark repo option.

Para probar el deploy habria que settear en CircleCI:

  • GITHUB_PERSONAL_TOKEN
  • DOCKER_USER
  • DOCKER_PASS

@matiasgarcia
matiasgarcia requested review from mdallago and werner April 9, 2021 15:02
@matiasgarcia matiasgarcia changed the title Change Dockerfile to checkout private repo Private Dockerfile Apr 9, 2021
@matiasgarcia

Copy link
Copy Markdown
Contributor Author

El build de la imagen me falla en el último paso, tal vez hay un problema de permisos en CircleCI

Step 18/20 : RUN service mysql start     && redis-server --daemonize yes --port 0 --unixsocket /tmp/redis.sock --unixsocketperm 775     && cd /usr/local/compliance && bundle exec rails db:setup
 ---> Running in 0c8be4f064e7
 * Starting MySQL database server mysqld
   ...fail!
The command '/bin/sh -c service mysql start     && redis-server --daemonize yes --port 0 --unixsocket /tmp/redis.sock --unixsocketperm 775     && cd /usr/local/compliance && bundle exec rails db:setup' returned a non-zero code: 1

Exited with code exit status 1

Comment thread .circleci/config.yml
TAG=0.1.$CIRCLE_BUILD_NUM
docker build --no-cache --build-arg GITHUB_PERSONAL_TOKEN=$GITHUB_PERSONAL_TOKEN -t bitex/compliance:$TAG docker/standalone
echo $DOCKER_PASS | docker login -u $DOCKER_USER --password-stdin
docker push bitex/compliance:$TAG

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esto crea una nueva imagen de docker cada vez que hay un build en circleci?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sí, de todas maneras lo vamos a cambiar porque es un dolor de huevos jeje

@matiasgarcia

Copy link
Copy Markdown
Contributor Author

Replaced by #356

@matiasgarcia
matiasgarcia deleted the private-repo-dockerfile branch April 14, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants