Private Dockerfile - #355
Closed
matiasgarcia wants to merge 7 commits into
Closed
Conversation
Contributor
Author
|
El build de la imagen me falla en el último paso, tal vez hay un problema de permisos en CircleCI |
werner
reviewed
Apr 13, 2021
| TAG=0.1.$CIRCLE_BUILD_NUM | ||
| docker build --no-cache --build-arg GITHUB_PERSONAL_TOKEN=$GITHUB_PERSONAL_TOKEN -t bitex/compliance:$TAG docker/standalone | ||
| echo $DOCKER_PASS | docker login -u $DOCKER_USER --password-stdin | ||
| docker push bitex/compliance:$TAG |
Contributor
There was a problem hiding this comment.
Esto crea una nueva imagen de docker cada vez que hay un build en circleci?
Contributor
Author
There was a problem hiding this comment.
Sí, de todas maneras lo vamos a cambiar porque es un dolor de huevos jeje
Contributor
Author
|
Replaced by #356 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/bitex-la/storyboard/issues/1699
How to test:
docker build --no-cache --build-arg GITHUB_PERSONAL_TOKEN=<YOUR_GITHUB_PERSONAL_TOKEN> .Get Access Token from https://github.com/settings/tokens -> Mark
repooption.Para probar el deploy habria que settear en CircleCI: